Ravenholdt/Calculateur-Talents-Wow
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update TODO

Browse Source
This commit is contained in:
Melvin Valster
2019-07-27 00:50:22 +02:00
parent c0507109e0
commit 3c06df0e6f
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODO.md
+1
View File
@@ -2,6 +2,7 @@
- [ ] Fix: Initial load `pointString` validation (make sure all talents are valid and their deps are met) - [ ] Fix: Initial load `pointString` validation (make sure all talents are valid and their deps are met)
- [ ] Fix: Navigating between talent links for same class does not trigger re-render - [ ] Fix: Navigating between talent links for same class does not trigger re-render
- [ ] Fix: Icon image fallback if not locally known
- [ ] Styling: - [ ] Styling:
- [ ] SCSS: Normalize - [ ] SCSS: Normalize
src/components/Icon.tsx
+1
View File
@@ -60,6 +60,7 @@ export const Icon = React.forwardRef<HTMLDivElement, Props>((props, ref) => {
) )
}) })
// TODO: Fallback is broken due to no longer using require()
const iconUrl = (name: string, size: string): string => { const iconUrl = (name: string, size: string): string => {
try { try {
return `${process.env.PUBLIC_URL}/images/icons/${size}/${name}.jpg` return `${process.env.PUBLIC_URL}/images/icons/${size}/${name}.jpg`